Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(213)

Issue 7179048: Add wrapper for "gcl try" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by EricB
Modified:
11 years, 8 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add wrapper for "gcl try" Adds some validation for --bot Committed: https://code.google.com/p/skia/source/detail?r=7315

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
A tools/gcl_try View 1 2 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 5
EricB
Addresses some of the issues in the suggestions doc. I'm hoping that this can also ...
11 years, 8 months ago (2013-01-22 17:11:54 UTC) #1
rmistry
https://codereview.appspot.com/7179048/diff/1/tools/gcl_try File tools/gcl_try (right): https://codereview.appspot.com/7179048/diff/1/tools/gcl_try#newcode7 tools/gcl_try:7: """ skia_try: Submit a try request. This is a ...
11 years, 8 months ago (2013-01-22 17:15:53 UTC) #2
EricB
Patch set 2. https://codereview.appspot.com/7179048/diff/1/tools/gcl_try File tools/gcl_try (right): https://codereview.appspot.com/7179048/diff/1/tools/gcl_try#newcode7 tools/gcl_try:7: """ skia_try: Submit a try request. ...
11 years, 8 months ago (2013-01-22 17:40:39 UTC) #3
rmistry
LGTM As discussed, we should extract constants that we would like to share between trunk ...
11 years, 8 months ago (2013-01-22 18:20:30 UTC) #4
EricB
11 years, 8 months ago (2013-01-22 18:24:18 UTC) #5
Message was sent while issue was closed.
On 2013/01/22 18:20:30, rmistry wrote:
> LGTM
> 
> As discussed, we should extract constants that we would like to share between
> trunk and buildbot into a JSON file that will be parsed by both code bases
(for
> trunk the JSON file will be hosted on http://code.google.com).

Filed https://code.google.com/p/skia/issues/detail?id=1081.

Committed as r7315.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b