Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7174044: Checking in version 1287 release binaries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by chrisha
Modified:
11 years, 3 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Checking in version 1287 release binaries. BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=1289

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+-17 lines, --16 lines) Patch
D syzygy/binaries/Benchmark_Chrome-0.1_r1152-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/Benchmark_Chrome-0.1_r1222-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/ETW-0.6.5.0-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/ETW_Db-0.1_r1213-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
D syzygy/binaries/ETW_Db-0.1_r844-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/benchmark.bat View 2 chunks +3 lines, -3 lines 0 comments Download
M syzygy/binaries/exe/README.TXT View 1 chunk +2 lines, -2 lines 1 comment Download
A + syzygy/binaries/exe/RELEASE-NOTES.TXT View 1 chunk +0 lines, -1 line 1 comment Download
M syzygy/binaries/exe/asan_rtl.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/basic_block_entry_client.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_client.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_control.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_service.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/coverage_client.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/decompose.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/decompose_image_to_text.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/dump_trace.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/experimental/code_tally.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/experimental/compare.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/experimental/pdb_dumper.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/experimental/timed_decomposer.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/grinder.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/instrument.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/logger.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/pdbfind.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/profile_client.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/relink.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/reorder.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot_x64.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot_xp.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/simulate.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/wsdump.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/zap_timestamp.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/instrument.bat View 2 chunks +3 lines, -3 lines 0 comments Download
M syzygy/binaries/optimize.bat View 2 chunks +3 lines, -3 lines 0 comments Download
M syzygy/binaries/profile.bat View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
chrisha
PTAL.
11 years, 3 months ago (2013-01-21 14:46:33 UTC) #1
chrisha
Committing, TBR.
11 years, 3 months ago (2013-01-21 15:08:34 UTC) #2
Roger McFarlane
11 years, 3 months ago (2013-01-21 15:10:06 UTC) #3 
lgtm with one additional readme blurb

https://codereview.appspot.com/7174044/diff/1/syzygy/binaries/exe/README.TXT
File syzygy/binaries/exe/README.TXT (right):

https://codereview.appspot.com/7174044/diff/1/syzygy/binaries/exe/README.TXT#...
syzygy/binaries/exe/README.TXT:46: 
Add the following blurb for logger.exe

A utility which accepts ASAN error logs (for binaries instrumented in ASAN mode)
across sandbox boundaries.

https://codereview.appspot.com/7174044/diff/1/syzygy/binaries/exe/RELEASE-NOT...
File syzygy/binaries/exe/RELEASE-NOTES.TXT (left):

https://codereview.appspot.com/7174044/diff/1/syzygy/binaries/exe/RELEASE-NOT...
syzygy/binaries/exe/RELEASE-NOTES.TXT:3: 
Is this necessary?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b