As Brian suggested in http://code.google.com/p/skia/issues/detail?id=1068 : - filter GM stdout before comparison - populate the comparison images automatically (both matching and nonmatching), so we don't have to check in new images whenever we have rendering changes I suspect this will also help with the following bugs: http://code.google.com/p/skia/issues/detail?id=1049 ('make gm/tests/rebaseline.sh update input images when rendering code changes') http://code.google.com/p/skia/issues/detail?id=677 ('make tools/tests/run.sh work cross-platform')
LGTM https://codereview.appspot.com/7164043/diff/2001/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/7164043/diff/2001/gm/tests/run.sh#newcode72 gm/tests/run.sh:72: grep --regexp=^reading --regexp=^writing --regexp=^drawing --regexp=^FAILED --regexp=^Ran $ACTUAL_OUTPUT_DIR/stdout >$ACTUAL_OUTPUT_DIR/stdout-tmp Nit: lets break up this line with \ https://codereview.appspot.com/7164043/diff/2001/gm/tests/run.sh#newcode104 gm/tests/run.sh:104: echo "more bytes that do not change the image pixels" >> $INPUTS_DIR/identical-pixels/8888/dashing2.png Nit: lets break up this line with \
https://codereview.appspot.com/7164043/diff/2001/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/7164043/diff/2001/gm/tests/run.sh#newcode72 gm/tests/run.sh:72: grep --regexp=^reading --regexp=^writing --regexp=^drawing --regexp=^FAILED --regexp=^Ran $ACTUAL_OUTPUT_DIR/stdout >$ACTUAL_OUTPUT_DIR/stdout-tmp On 2013/01/18 12:09:36, rmistry wrote: > Nit: lets break up this line with \ Good idea. Done through much of this file.
