Issue 71510043: Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 71510043: Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l…

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Xia Lu

Modified:
10 years, 8 months ago

Reviewers:
arnold.koroa

Visibility:
Public.

More Reviews

Description

Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l…

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l… #

Patch Set 3 : Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l… #

Patch Set 4 : Issue1596: Enrolling multiple with the same email will enroll the first students' email using the l… #

Created: 10 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -14 lines)			Patch
M	src/main/java/teammates/logic/core/StudentsLogic.java	View	1 2 3	3 chunks	+23 lines, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/logic/LogicTest.java	View	1 2 3	1 chunk	+26 lines, -8 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/StudentsLogicTest.java	View	1 2 3	2 chunks	+5 lines, -6 lines	0 comments	Download
M	upload.py	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arnold.koroa

10 years, 8 months ago (2014-03-06 03:35:57 UTC) #1

https://codereview.appspot.com/71510043/diff/1/src/main/java/teammates/logic/...
File src/main/java/teammates/logic/core/StudentsLogic.java (right):

https://codereview.appspot.com/71510043/diff/1/src/main/java/teammates/logic/...
src/main/java/teammates/logic/core/StudentsLogic.java:477: info.add("Same email
address as the one in line \"" + linesArray[studentEmailList.indexOf(email)]+
"\"");
"Same email address as the student in line..." ?

Expand All Messages | Collapse All Messages