Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4320)

Issue 7147044: Don't die when there are no fonts available. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by bungeman
Modified:
11 years, 5 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Don't die when there are no fonts available.

Patch Set 1 #

Patch Set 2 : Remove unintended testing modification. #

Total comments: 2

Patch Set 3 : Fix sentinal values instead. #

Patch Set 4 : Use NaN as the sentinal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/core/SkPictureFlat.h View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M src/core/SkPictureFlat.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/FontHostStreamTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
bungeman
On ChromeOS there is (by default) no /usr/share/fonts/truetype/ directory (they are all in other subdirectories). ...
11 years, 5 months ago (2013-01-17 19:15:25 UTC) #1
bungeman
Alternative approach.
11 years, 5 months ago (2013-01-17 19:33:17 UTC) #2
bungeman
Now using NaN as the sentinel value, and changed to uniformally use writable/written.
11 years, 5 months ago (2013-01-17 20:02:37 UTC) #3
reed1
lgtm
11 years, 5 months ago (2013-01-17 20:08:26 UTC) #4
bungeman
11 years, 5 months ago (2013-01-17 20:51:23 UTC) #5
Message was sent while issue was closed.
Committed revision 7265.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b