Issue 7141048: path/filepath: support joining (lists of) filepaths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7141048: path/filepath: support joining (lists of) filepaths

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by speter

Modified:
11 years, 2 months ago

Reviewers:

Visibility:
Public.

Description

path/filepath: support joining (lists of) filepaths (temporarily reverted to resolve conflict with issue 7181047) This CL targets the following use cases: U1: join individual filepaths into a list U2: join lists of filepaths into a list U3: append / prepend individual filepaths to a list JoinFilepaths is added to solve U1, and JoinLists to solve U2. U3 can be solved by a combination of the two. Examples are added for each use case. Type List is added to reduce the chance of users incorrectly using individual filepaths as lists or the other way around (potentially leading to security issues).

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	A	src/pkg/path/filepath/dummy	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Issue 7141048: path/filepath: support joining (lists of) filepaths

Description

Patch Set 1 #

Patch Set 2 : diff -r 3914255bcf5f https://code.google.com/p/go #

Patch Set 3 : code review 7141048: path/filepath: support joining (lists of) filepaths #

Patch Set 4 : diff -r 3a153f3d2680 https://code.google.com/p/go #