Issue 7138056: Reapply r7198 with Mac/Windows fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7138056: Reapply r7198 with Mac/Windows fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by epoger

Modified:
11 years, 7 months ago

Reviewers:
EricB, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Reapply r7198 with Mac/Windows fixes BUG=https://code.google.com/p/skia/issues/detail?id=1067 Committed: https://code.google.com/p/skia/source/detail?r=7258

Patch Set 1 #

Patch Set 2 : windows_fix #

Patch Set 3 : mac_fix #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+412 lines, -205 lines)			Patch
A	gm/gm_expectations.h	View	1 2	1 chunk	+174 lines, -0 lines	0 comments	Download
M	gm/gmmain.cpp	View	1	28 chunks	+237 lines, -204 lines	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

epoger

patchset 1 simply reapplies r7198 (merged with subsequent changes)

11 years, 7 months ago (2013-01-17 15:18:41 UTC) #1

epoger

First LG wins... When reviewing, you will probably find it simplest to look at the ...

11 years, 7 months ago (2013-01-17 16:11:36 UTC) #2

bsalomon

On 2013/01/17 16:11:36, epoger wrote: > First LG wins... > > When reviewing, you will probably ...

11 years, 7 months ago (2013-01-17 16:13:11 UTC) #3

epoger

This is very exciting... I have just sent the patch to some of our new ...

11 years, 7 months ago (2013-01-17 16:27:50 UTC) #4

epoger

11 years, 7 months ago (2013-01-17 17:54:06 UTC) #5

Mixed success on the buildbots...

> http://70.32.156.51:10117/builders/Skia_Mac_Float_Debug_64_Trybot/builds/8

Succeeds through BuildGM step and beyond!  This is a great indication that the
change will work better than before.

And
http://70.32.156.51:10117/builders/Skia_Mac_Float_Debug_64_Trybot/builds/8/st...
demonstrates that the change really is getting applied as I expect.  Nice!

>
http://70.32.156.51:10117/builders/Skia_Shuttle_Win7_Intel_Float_ANGLE_Releas...

Failed the ApplyPatch step.  Looks like this particular trybot might not be
ready for prime time.

>
http://70.32.156.51:10117/builders/Skia_MacMiniLion_Float_Debug_64_Trybot/bui...

Succeeds through BuildGM step and beyond, like r7198 did previously on this
builder.  A nice confirmation...

Expand All Messages | Collapse All Messages