Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(823)

Issue 7137046: Add option to ignore small pixel diffs for --validate. By default, right (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by edisonn
Modified:
11 years, 8 months ago
Reviewers:
EricB, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add option to ignore small pixel diffs for --validate. By default, right now we will default to max diff of 256, which means that for now we report all pixels that are not as expected and we do not error out. Ideally we will decrease the value of max diff to something that does not have visual impact, e.g. 10, then we will report small changes with the intensity under 10, but we will error out for anything larger. Committed: https://code.google.com/p/skia/source/detail?r=7232

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -20 lines) Patch
M tools/render_pictures_main.cpp View 1 11 chunks +62 lines, -20 lines 0 comments Download

Messages

Total messages: 4
edisonn
11 years, 8 months ago (2013-01-16 15:47:25 UTC) #1
reed1
https://codereview.appspot.com/7137046/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/7137046/diff/1/tools/render_pictures_main.cpp#newcode178 tools/render_pictures_main.cpp:178: SkMax32 already exists https://codereview.appspot.com/7137046/diff/1/tools/render_pictures_main.cpp#newcode180 tools/render_pictures_main.cpp:180: The caller is not ...
11 years, 8 months ago (2013-01-16 16:06:39 UTC) #2
edisonn
https://codereview.appspot.com/7137046/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/7137046/diff/1/tools/render_pictures_main.cpp#newcode178 tools/render_pictures_main.cpp:178: On 2013/01/16 16:06:41, reed1 wrote: > SkMax32 already exists ...
11 years, 8 months ago (2013-01-16 16:52:29 UTC) #3
reed1
11 years, 8 months ago (2013-01-16 17:50:41 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b