Issue 7135062: Remove dependency on DirectX SDK.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7135062: Remove dependency on DirectX SDK. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by apatrick1

Modified:
11 years, 8 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/branches/dx11proto/

Visibility:
Public.

More Reviews

Description

Remove dependency on DirectX SDK. Committed: https://code.google.com/p/angleproject/source/detail?r=1723

Patch Set 1 : #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/build_angle.gypi	View		1 chunk	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dgkoch

LGTM (as long as you are aware that the Win8 SDK doesn't work on WinXP) ...

11 years, 8 months ago (2013-01-19 20:19:09 UTC) #3

apatrick1

This is a gyp change so it should only affect Chrome. We are dynamically loading ...

11 years, 8 months ago (2013-01-22 22:02:03 UTC) #4

dgkoch

11 years, 8 months ago (2013-01-22 22:12:42 UTC) #5

On 2013/01/22 22:02:03, apatrick1 wrote:
> This is a gyp change so it should only affect Chrome. We are dynamically
loading
> the D3DCompiler DLL and will continue to bundle the 43 version of it in the
> installer for as long as we support ANGLE on XP. I think ANGLE built against
the
> Win8 SDK will still work with a dynamically loaded D3DCompiler_43.dll. It
seems
> to be working for me at least.

Right - you're dynamically loading them.  That should be fine then. LGTM.

Expand All Messages | Collapse All Messages