Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 7135060: This patch fixes the existing blend modes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by RikC
Modified:
12 years, 11 months ago
Reviewers:
caryclark1;reed, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This patch fixes the existing blend modes. It also introduces a new 'multiply' blend mode. This mode is different from the existing one that just multiplies all components (instead of doing actual blending). Hard-light and overlay have some rounding issues. This will be addressed later. This patch also does not add the non-separable blend modes. See review for 7103061. BUG=1037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -147 lines) Patch
M include/core/SkXfermode.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +180 lines, -146 lines 0 comments Download

Messages

Total messages: 7
reed1
12 years, 11 months ago (2013-01-22 19:01:02 UTC) #1
reed1
Good catch on MULTIPLY. The old code was written to support modulating between two shaders ...
12 years, 11 months ago (2013-01-22 19:31:04 UTC) #2
reed1
For sanity, perhaps we should just do #1 first (the rename), so we're sure we ...
12 years, 11 months ago (2013-01-22 19:33:11 UTC) #3
RikC
On 2013/01/22 19:33:11, reed1 wrote: > For sanity, perhaps we should just do #1 first ...
12 years, 11 months ago (2013-01-22 23:48:41 UTC) #4
reed1
Yes, I suggest two sequential CLs. 1. rename the existing Multiply to Modulate (and fix ...
12 years, 11 months ago (2013-01-23 14:07:43 UTC) #5
RikC
On 2013/01/23 14:07:43, reed1 wrote: > Yes, I suggest two sequential CLs. > > 1. ...
12 years, 11 months ago (2013-01-23 18:47:11 UTC) #6
RikC
12 years, 11 months ago (2013-01-23 19:01:01 UTC) #7
On 2013/01/23 18:47:11, RikC wrote:
> On 2013/01/23 14:07:43, reed1 wrote:
> > Yes, I suggest two sequential CLs.
> > 
> > 1. rename the existing Multiply to Modulate (and fix up existing skia
callers)
> Who are the existing callers? Is it anything that uses skia (such as chrome?)
or
> just the test files?
> 
> > 2. add Multiply (implemented to match CSS spec).
> Will do.

Added multiply to modulate patch with https://codereview.appspot.com/7205045/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b