Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(2204)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Delta Between Two Patch Sets: doc/progs/unused2.go
Issue
7134056
:
code review 7134056: doc/effective_go.html: add a section about the blank id... (Closed)
Left Patch Set: diff -r d96fe1298b88 https://go.googlecode.com/hg/
Created 12 years, 2 months ago
Right Patch Set: diff -r b68f084eaba7 https://go.googlecode.com/hg/
Created 12 years, 2 months ago
Left:
Base
Patch Set 1: None
Patch Set 2: diff -r d96fe1298b88 https://go.googlecode.com/hg/
Patch Set 3: diff -r d96fe1298b88 https://go.googlecode.com/hg/
Patch Set 4: diff -r 6ba201b58519 https://go.googlecode.com/hg/
Patch Set 5: diff -r c9c786583d50 https://go.googlecode.com/hg/
Patch Set 6: diff -r b68f084eaba7 https://go.googlecode.com/hg/
Right:
Patch Set 1: None
Patch Set 2: diff -r d96fe1298b88 https://go.googlecode.com/hg/
Patch Set 3: diff -r d96fe1298b88 https://go.googlecode.com/hg/
Patch Set 4: diff -r 6ba201b58519 https://go.googlecode.com/hg/
Patch Set 5: diff -r c9c786583d50 https://go.googlecode.com/hg/
Patch Set 6: diff -r b68f084eaba7 https://go.googlecode.com/hg/
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
doc/effective_go.html
doc/progs/unused1.go
doc/progs/unused2.go
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« doc/progs/unused1.go
('k') |
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
1
// compile
2
1 package main
3 package main
2
4
3 import (
5 import (
4 "fmt"
6 "fmt"
5 "io"
7 "io"
6 )
8 )
7
9
8 var _ = fmt.Printf
10 var _ = fmt.Printf
9 var _ io.Reader
11 var _ io.Reader
10
12
11 func main() {
13 func main() {
12 greeting := "hello, world"
14 greeting := "hello, world"
13 _ = greeting
15 _ = greeting
14 }
16 }
LEFT
RIGHT
« doc/progs/unused1.go
('k') |
no next file »
|
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Issue 7134056: code review 7134056: doc/effective_go.html: add a section about the blank id... (Closed)
Created 12 years, 2 months ago by rsc
Modified 12 years, 2 months ago
Reviewers:
Base URL:
Comments: 12
Recent Issues
|
This issue
This is Rietveld
f62528b