Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1948)

Issue 7132060: re-land r7258 with fixes and tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by epoger
Modified:
11 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com, robertphillips, senorblanco
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

re-land r7258 with fixes and tests BUG=http://code.google.com/p/skia/issues/detail?id=1079 TBR=reed Committed: https://code.google.com/p/skia/source/detail?r=7291

Patch Set 1 #

Patch Set 2 : add_test_that_demonstrates_failure #

Patch Set 3 : fixed_by_forcing_bitmaps_opaque #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -203 lines) Patch
A + gm/gm_expectations.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/gmmain.cpp View 1 2 28 chunks +308 lines, -202 lines 0 comments Download
A gm/tests/outputs/aaclip-readback/output-expected/command_line View 1 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt View 1 1 chunk +39 lines, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-readback/output-expected/return_value View 1 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-readback/output-expected/stdout View 1 1 chunk +6 lines, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-write/output-expected/command_line View 1 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-write/output-expected/json-summary.txt View 1 1 chunk +22 lines, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-write/output-expected/return_value View 1 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/aaclip-write/output-expected/stdout View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/run.sh View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 3
epoger
patchset 1 just re-lands r7258; now to make it work better...
11 years, 11 months ago (2013-01-19 01:22:32 UTC) #1
epoger
I'm going to go ahead and commit this, so that development in gmmain.cpp can keep ...
11 years, 11 months ago (2013-01-19 04:21:02 UTC) #2
epoger
11 years, 11 months ago (2013-01-19 05:43:17 UTC) #3
This CL caused a couple of new failures, which I fixed in
https://codereview.appspot.com/7129057 .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b