Issue 7131043: quick fix for GM self-test failures after r7206

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7131043: quick fix for GM self-test failures after r7206 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by epoger

Modified:
11 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

quick fix for GM self-test failures after r7206 BUG=http://code.google.com/p/skia/issues/detail?id=1068 Committed: https://code.google.com/p/skia/source/detail?r=7213 TBR=bsalomon

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	gm/tests/outputs/compared-against-different-pixels/output-expected/stdout	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/stdout	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes/output-expected/stdout	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels/output-expected/stdout	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/stdout	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

epoger

11 years, 11 months ago (2013-01-16 03:38:23 UTC) #1

Longer-term discussion in the bug, but for now...

Here's how I rebaselined this... note that this must be run on Linux.
$ make gm BUILDTYPE=Debug
$ gm/tests/run.sh          # and see it fail
$ gm/tests/rebaseline.sh   # repeat until clean
$ gm/tests/run.sh          # now it succeeds
$ svn commit

Expand All Messages | Collapse All Messages