Issue 7128056: gm self-test: followup to r7284

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7128056: gm self-test: followup to r7284 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by epoger

Modified:
11 years, 7 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

gm self-test: followup to r7284 TBR=rmistry Committed: https://code.google.com/p/skia/source/detail?r=7286

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -13 lines)			Patch
M	gm/tests/outputs/compared-against-different-pixels/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gm/tests/outputs/compared-against-different-pixels/output-expected/images/8888/dashing2.png	View	Binary file		0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels/output-expected/stdout	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gm/tests/outputs/compared-against-empty-dir/output-expected/images/8888/dashing2.png	View	Binary file		0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/stdout	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gm/tests/outputs/compared-against-identical-bytes/output-expected/images/8888/dashing2.png	View	Binary file		0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes/output-expected/stdout	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gm/tests/outputs/compared-against-identical-pixels/output-expected/images/8888/dashing2.png	View	Binary file		0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels/output-expected/stdout	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gm/tests/outputs/no-readpath/output-expected/images/8888/dashing2.png	View	Binary file		0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/stdout	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/tests/run.sh	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

No longer write the actual images out, since we don't want to keep an up-to-date ...

11 years, 9 months ago (2013-01-18 20:05:26 UTC) #1

LGTM

Expand All Messages | Collapse All Messages