Issue 71180043: Properly reject add/remove reader/writer on closed event loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 71180043: Properly reject add/remove reader/writer on closed event loop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by GvR

Modified:
11 years, 11 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Properly reject add/remove reader/writer on closed event loop

Patch Set 2 : Use with assertRaises #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	asyncio/selector_events.py	View		4 chunks	+8 lines, -0 lines	0 comments	Download
	M	tests/test_events.py	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yselivanov

https://codereview.appspot.com/71180043/diff/1/tests/test_events.py File tests/test_events.py (right): https://codereview.appspot.com/71180043/diff/1/tests/test_events.py#newcode1344 tests/test_events.py:1344: self.assertRaises(RuntimeError, loop.add_reader, r, callback) Just a minor question -- ...

11 years, 11 months ago (2014-03-04 17:18:00 UTC) #1

GvR

11 years, 11 months ago (2014-03-04 17:47:40 UTC) #3

Committing.

Expand All Messages | Collapse All Messages