Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(597)

Issue 7111043: Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRender… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by junov1
Modified:
11 years, 5 months ago
Reviewers:
epoger, EricB
CC:
skia-review_googlegroups.com, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRenderer Chrome uses this flag for recording to skpicture in order to improve performance. Therefore, skai benchmarks should run with this flag enabled, and we need gm and render_pictures test coverage to validate it. In gm, the vanilla SkPicture test step will still run without the flag to ensure that case still gets test coverage, while the SkPicture test steps that use rtree and tileGrid will now run with the flag enabled. Committed: https://code.google.com/p/skia/source/detail?r=7234

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M bench/benchmain.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M gm/gmmain.cpp View 5 chunks +9 lines, -6 lines 3 comments Download
M tools/PictureRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
junov
11 years, 5 months ago (2013-01-15 16:45:05 UTC) #1
EricB
LGTM with some style nits
11 years, 5 months ago (2013-01-15 19:46:19 UTC) #2
EricB
Accidentally didn't publish comments... https://codereview.appspot.com/7111043/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.appspot.com/7111043/diff/1/gm/gmmain.cpp#newcode620 gm/gmmain.cpp:620: static SkPicture* generate_new_picture(GM* gm, BbhType ...
11 years, 5 months ago (2013-01-15 20:15:19 UTC) #3
epoger
11 years, 5 months ago (2013-01-16 21:06:08 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b