Normalize charm URLs in bundles

Normalize charm URLs in bundles

This branch normalizes the charm URLs in bundles for the GUI, which is expecting at least a <schema>:<series>/<name> style URL.  Current proof allows bundles with charms specified only by name, so long as they're in the charmstore already.

Caveats:
* Currently only works on ingest
* Will require a GUI branch as well to add -HEAD if no version number (a smart move anyway)


QA:
* Run
* bin/enqueue --prefix=~bac/charms/bundles
* bin/ingest-queued --prefix=~bac/charms/bundles --limit=100
* Get bac's bundle wiki:wiki - the charms should all have a charm: attribute, and the attributes should all be URLs as specified above.

https://code.launchpad.net/~makyo/charmworld/charm-urls/+merge/209556

(do not edit description out of merge proposal)

[matthew.scott, 2014-03-05 23:23:09]

Please take a look.

[rharding, 2014-03-06 13:57:19]

"Will require a GUI branch as well to add -HEAD if no version number (a smart
move anyway)"

Have you verified this is true? I don't think that the -HEAD is required. It was
a temp hack until revisionless url support was added to charmworld.

[rharding, 2014-03-06 14:42:35]

LGTM with the note on verifying that you can't have mysql-15 and lose that info.
I'm not sure if we support that form or not currently. If not, no big deal, but
if we do, we should make sure to respect it. 

Have not qa'd yet.

https://codereview.appspot.com/71070051/diff/1/charmworld/jobs/ingest.py
File charmworld/jobs/ingest.py (right):

https://codereview.appspot.com/71070051/diff/1/charmworld/jobs/ingest.py#newc...
charmworld/jobs/ingest.py:101: self.services_info =
proof_output.get('services_info')
can this be no service info? Should it be .get('services_info', None)?

https://codereview.appspot.com/71070051/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/71070051/diff/1/charmworld/models.py#newcode1807
charmworld/models.py:1807: info['charm'] != services_info[name]['store_url']:
can you put a comment in here about that dropping of the version? 

Should this check if there's a version on the existing info? I just want to make
sure we don't alter the bundle in a way that's negative.

[matthew.scott, 2014-03-06 16:12:20]

On 2014/03/06 13:57:19, rharding wrote:
> "Will require a GUI branch as well to add -HEAD if no version number (a smart
> move anyway)"
> 
> Have you verified this is true? I don't think that the -HEAD is required. It
was
> a temp hack until revisionless url support was added to charmworld.

I think the problem we ran into was juju-gui tried to fetch the 'gui' version of
juju.  Will confirm.

[benji, 2014-03-06 19:39:55]

LGTM