Issue 1643: InstructorFeedbackResultDownload: add team column to the csv file

Issue 1643: InstructorFeedbackResultDownload: add team column to the csv file

[damith, 2014-03-04 06:23:43]

https://codereview.appspot.com/71070043/diff/20001/src/main/java/teammates/lo...
File src/main/java/teammates/logic/core/FeedbackSessionsLogic.java (right):

https://codereview.appspot.com/71070043/diff/20001/src/main/java/teammates/lo...
src/main/java/teammates/logic/core/FeedbackSessionsLogic.java:266: }
if you add a public method, remember to add tests.

https://codereview.appspot.com/71070043/diff/20001/src/main/java/teammates/lo...
src/main/java/teammates/logic/core/FeedbackSessionsLogic.java:726: String
feedbackSessionName, String courseId, String userEmail, UserType.Role role,
Boolean isCsvDownload)
I don't like adding additional parameters to control the logic of a method. What
if this method returns the team column all the time? That behavior is consistent
with the method name. Those who call the method can ignore that column if they
don't want to. Try that.
If we were to use an extra parameter (i don't want to :-p), the parameter name
should be about the difference in logic that it causes, not how it is used by
callers. e.g. it should be isTeamColumnIncluded, not isCsvDownload.

[damith, 2014-03-04 15:13:45]

https://codereview.appspot.com/71070043/diff/80001/src/main/java/teammates/lo...
File src/main/java/teammates/logic/core/FeedbackSessionsLogic.java (right):

https://codereview.appspot.com/71070043/diff/80001/src/main/java/teammates/lo...
src/main/java/teammates/logic/core/FeedbackSessionsLogic.java:897: 
The return type is a bit odd. May be add a comment to explain the method
behavior?