Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4426)

Issue 7105049: Reorganized new sources from recently applied patch into third_party directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by kbr1
Modified:
11 years, 3 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Reorganized new sources from recently applied patch into third_party directory. Committed: https://code.google.com/p/angleproject/source/detail?r=1719

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -157 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M src/build_angle.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
D src/compiler/ArrayBoundsClamper.h View 1 chunk +0 lines, -57 lines 0 comments Download
D src/compiler/ArrayBoundsClamper.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M src/compiler/Compiler.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/ShHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/translator_common.vcxproj View 4 chunks +2 lines, -2 lines 0 comments Download
A + src/third_party/compiler/ArrayBoundsClamper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + src/third_party/compiler/ArrayBoundsClamper.cpp View 1 chunk +1 line, -1 line 0 comments Download
A src/third_party/compiler/LICENSE View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A src/third_party/compiler/README.angle View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8
kbr1
11 years, 3 months ago (2013-01-12 00:12:08 UTC) #1
apatrick1
https://codereview.appspot.com/7105049/diff/2001/src/compiler/Compiler.cpp File src/compiler/Compiler.cpp (right): https://codereview.appspot.com/7105049/diff/2001/src/compiler/Compiler.cpp#newcode22 src/compiler/Compiler.cpp:22: #include "third_party/compiler/ArrayBoundsClamper.h" #include "../third_party/compiler/ArrayBoundsClamper.h" https://codereview.appspot.com/7105049/diff/2001/src/compiler/ShHandle.h File src/compiler/ShHandle.h (right): https://codereview.appspot.com/7105049/diff/2001/src/compiler/ShHandle.h#newcode25 ...
11 years, 3 months ago (2013-01-12 00:35:00 UTC) #2
vangelis
Thanks, Ken! In addition you should follow the guidelines here: http://www.chromium.org/developers/adding-3rd-party-libraries and add a README ...
11 years, 3 months ago (2013-01-12 01:42:20 UTC) #3
kbr1
README and LICENSE added. They pass the presubmit checks. Please review.
11 years, 3 months ago (2013-01-14 21:06:51 UTC) #4
vangelis
On 2013/01/14 21:06:51, kbr1 wrote: > README and LICENSE added. They pass the presubmit checks. ...
11 years, 3 months ago (2013-01-14 21:52:22 UTC) #5
vangelis
LGTM. Just one nit (sorry I forgot to mention it before). Would you mind renaming: ...
11 years, 3 months ago (2013-01-14 22:39:41 UTC) #6
kbr1
On 2013/01/14 22:39:41, vangelis wrote: > LGTM. Just one nit (sorry I forgot to mention ...
11 years, 3 months ago (2013-01-14 22:45:35 UTC) #7
vangelis
11 years, 3 months ago (2013-01-14 23:43:42 UTC) #8
Message was sent while issue was closed.
On 2013/01/14 22:45:35, kbr1 wrote:
> On 2013/01/14 22:39:41, vangelis wrote:
> > LGTM.  Just one nit (sorry I forgot to mention it before).  Would you mind
> > renaming:
> > 
> > README.chromium
> > 
> > to something like
> > 
> > README.angle
> > 
> > ?
> 
> Done.

LGTM again

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b