Added print out of SkShader information to debugger

Added print out of SkShader information to debugger

[Humper, 2013-01-12 20:05:12]

https://codereview.appspot.com/7105045/diff/2001/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7105045/diff/2001/debugger/SkObjectParser.cpp#...
debugger/SkObjectParser.cpp:158: shader->toDumpString(mPaint);
Maybe this is standard skia convention, but toDumpString seems not quite as good
as dumpToString to me.

I can pick nits with the best of them!

[robertphillips, 2013-01-13 20:06:54]

https://codereview.appspot.com/7105045/diff/2001/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7105045/diff/2001/debugger/SkObjectParser.cpp#...
debugger/SkObjectParser.cpp:158: shader->toDumpString(mPaint);
Initially I had these methods named 'asAString' to match the 'asNewEffect',
'asAGradient', and 'asABitmap' SkShader "convention". When I decided to reuse
parts of the dump canvas (e.g., the pre-existing 'SkMatrix::toDumpString' and
'SkBitmapProcShader::toDumpString') I swapped everything to 'toDumpString'. The
dump canvas just uses 'toString' internally (since it is clear in that context
that the strings are for the dump canvas). I believe the 'dumpString' suffix was
used for external methods to indicate that the methods were intended for the
dump canvas.

We should agree on a standard naming convention since these methods will be
propagating to additional classes (e.g., SkXfermode, SkColorFilter, etc.).

[robertphillips, 2013-01-14 14:19:14]

Per local conversation we are going to:

change toDumpString -> toString
wrap all toString's in DEV_MODE macros
force DEV_MODE on in debug mode

[robertphillips, 2013-01-15 15:50:33]

PTAL

[DerekS, 2013-01-15 16:52:51]

https://codereview.appspot.com/7105045/diff/7001/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7105045/diff/7001/debugger/SkObjectParser.cpp#...
debugger/SkObjectParser.cpp:158: SkDEVCODE(shader->toString(mPaint);)
do we want to guard this or have the compile fail if SK_DEVELOPER is not enabled
for the debugger?

https://codereview.appspot.com/7105045/diff/7001/experimental/Debugger/Debugg...
File experimental/Debugger/DebuggerContentView.cpp (right):

https://codereview.appspot.com/7105045/diff/7001/experimental/Debugger/Debugg...
experimental/Debugger/DebuggerContentView.cpp:2: #ifdef SK_DEVELOPER
I'm going to see about killing off this directory, so this will probably be
obsolete.

https://codereview.appspot.com/7105045/diff/7001/include/core/SkColorShader.h
File include/core/SkColorShader.h (right):

https://codereview.appspot.com/7105045/diff/7001/include/core/SkColorShader.h...
include/core/SkColorShader.h:51: SkDEVCODE(virtual void toString(SkString* str)
const SK_OVERRIDE;)
what do you think of making a macro for this? Something like
SK_DEVELOPER_TO_STRING()?

https://codereview.appspot.com/7105045/diff/7001/include/effects/SkTransparen...
File include/effects/SkTransparentShader.h (right):

https://codereview.appspot.com/7105045/diff/7001/include/effects/SkTransparen...
include/effects/SkTransparentShader.h:23: SkDEVCODE(virtual void   
toString(SkString* str) const SK_OVERRIDE;)
spacing?

[robertphillips, 2013-01-15 19:38:04]

https://codereview.appspot.com/7105045/diff/7001/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7105045/diff/7001/debugger/SkObjectParser.cpp#...
debugger/SkObjectParser.cpp:158: SkDEVCODE(shader->toString(mPaint);)
I don't think we have to fail. I just planned on having the debugger not print
all the info in the non-developer builds.

https://codereview.appspot.com/7105045/diff/7001/include/core/SkColorShader.h
File include/core/SkColorShader.h (right):

https://codereview.appspot.com/7105045/diff/7001/include/core/SkColorShader.h...
include/core/SkColorShader.h:51: SkDEVCODE(virtual void toString(SkString* str)
const SK_OVERRIDE;)
On 2013/01/15 16:52:51, DerekS wrote:
> what do you think of making a macro for this? Something like
> SK_DEVELOPER_TO_STRING()?

Done.

https://codereview.appspot.com/7105045/diff/7001/include/effects/SkTransparen...
File include/effects/SkTransparentShader.h (right):

https://codereview.appspot.com/7105045/diff/7001/include/effects/SkTransparen...
include/effects/SkTransparentShader.h:23: SkDEVCODE(virtual void   
toString(SkString* str) const SK_OVERRIDE;)
OBE

[DerekS, 2013-01-15 20:08:12]

lgtm

[robertphillips, 2013-01-15 20:18:23]

committed as r7201