Issue 7103062: [PATCH] configure: don't echo $CFLAGS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7103062: [PATCH] configure: don't echo $CFLAGS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by minux1

Modified:
12 years, 1 month ago

Reviewers:
jakub, bonzini, mikestump, dj, neroden, richard.guenther, ralf.wildenhues, aoliva

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn://gcc.gnu.org/svn/gcc/trunk/

Visibility:
Public.

Description

2013-01-20 Shenghou Ma <minux.ma@gmail.com> * config/isl.m4: don't echo $CFLAGS for ISL_CHECK_VERSION. * configure: Re-generate.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	config/isl.m4	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	configure	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

richard.guenther_gmail.com

12 years, 3 months ago (2013-01-23 12:45:57 UTC) #2

On Sun, Jan 20, 2013 at 12:02 PM,  <minux.ma@gmail.com> wrote:
> Reviewers: bonzini_gnu.org, dj_redhat.com, neroden_gcc.gnu.org,
> aoliva_redhat.com, ralf.wildenhues_gmx.de, jakub_redhat.com,
> mikestump_comcast.net,

Ok.

Thanks
Richard.

> Description:
> 2013-01-20  Shenghou Ma  <minux.ma@gmail.com>
>
>         * config/isl.m4: don't echo $CFLAGS for ISL_CHECK_VERSION.
>         * configure: Re-generate.
>
>
> Please review this at https://codereview.appspot.com/7103062/
>
> Affected files:
>   M     config/isl.m4
>   M     configure
>
>
> Index: configure
> ===================================================================
> --- configure   (revision 195313)
> +++ configure   (working copy)
> @@ -5833,7 +5833,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.10 of
> ISL" >&5
>  $as_echo_n "checking for version 0.10 of ISL... " >&6; }
> @@ -5882,7 +5881,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.11 of
> ISL" >&5
>  $as_echo_n "checking for version 0.11 of ISL... " >&6; }
> Index: config/isl.m4
> ===================================================================
> --- config/isl.m4       (revision 195313)
> +++ config/isl.m4       (working copy)
> @@ -114,7 +114,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      AC_MSG_CHECKING([for version $1.$2 of ISL])
>      AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2)],
>
>

Expand All Messages | Collapse All Messages