Issue 7098066: Re-enable inst counting in debug builds.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7098066: Re-enable inst counting in debug builds. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Re-enable inst counting in debug builds. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7206

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -22 lines)			Patch
M	bench/benchmain.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/gmmain.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/config/SkUserConfig.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkInstCnt.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	include/core/SkPostConfig.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/core/SkInstCnt.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/GrMemoryPoolTest.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/LListTest.cpp	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/skia_test.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/bench_pictures_main.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

bsalomon

Related Chrome change to ensure Chrome doesn't build the inst counting code: https://codereview.chromium.org/11927002

11 years, 5 months ago (2013-01-15 20:21:55 UTC) #1

robertphillips

11 years, 5 months ago (2013-01-15 20:25:03 UTC) #2

LGTM - thanks for doing this - it has been on my low-priority TODO list for a
while