Issue 7098063: To support alignment pragmas (for speed), we need to relax assumptions about

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7098063: To support alignment pragmas (for speed), we need to relax assumptions about (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by reed1

Modified:
11 years, 10 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

To support alignment pragmas (for speed), we need to relax assumptions about our sizeof. So rewrite operator= and copy-constructor to just copy individual fields. Committed: https://code.google.com/p/skia/source/detail?r=7181

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -22 lines)			Patch
	M	trunk/include/utils/SkMatrix44.h	View		4 chunks	+13 lines, -11 lines	0 comments	Download
	M	trunk/src/utils/SkMatrix44.cpp	View		2 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM, I suppose. We could spend time benchmarking, but I don't know that it's worth ...

11 years, 10 months ago (2013-01-15 13:41:18 UTC) #2

just opportunistic

Expand All Messages | Collapse All Messages