Issue 7098054: dashing asPoints could draw excessively long first dash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7098054: dashing asPoints could draw excessively long first dash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by robertphillips

Modified:
11 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The asPoints dashing code ignored the case where the dash length was greater then the dashed line. The prototypical case from Webkit is 255on/255off dashing on a 10 pixel long line. In this case the code would draw a very long initial dash. This CL fixes this oversight and adds a gm to catch regressions. The debugger change just makes it easier to see what is going on with drawPoints calls.

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -16 lines)			Patch
M	debugger/SkDrawCommand.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gm/dashing.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/effects/SkDashPathEffect.cpp	View	4 chunks	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

committed as r7177

Expand All Messages | Collapse All Messages