Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 7098047: Separate our jsoncpp dependency from Chromium's jsoncpp overrides. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by epoger
Modified:
11 years, 10 months ago
Reviewers:
bungeman, DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Separate our jsoncpp dependency from Chromium's jsoncpp overrides. BUG=https://code.google.com/p/skia/issues/detail?id=909 Committed: https://code.google.com/p/skia/source/detail?r=7187

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M DEPS View 1 chunk +2 lines, -3 lines 1 comment Download
M gyp/jsoncpp.gyp View 2 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 3
epoger
Alternative to https://codereview.appspot.com/7063059/ ('Depend only on "real" jsoncpp repository, not chromium's wrapper of it') that ...
11 years, 11 months ago (2013-01-11 21:03:17 UTC) #1
DerekS
lgtm
11 years, 10 months ago (2013-01-14 14:27:58 UTC) #2
bungeman
11 years, 10 months ago (2013-01-14 19:05:44 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b