Add option to render PDFs to memory only.

Add option to render PDFs to memory only.
Committed: https://code.google.com/p/skia/source/detail?r=7140

[edisonn, 2013-01-11 19:48:28]

Required by https://codereview.appspot.com/6940081/

[epoger, 2013-01-11 20:00:17]

https://codereview.appspot.com/7097045/diff/1/tools/PdfRenderer.cpp
File tools/PdfRenderer.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/PdfRenderer.cpp#newcode51
tools/PdfRenderer.cpp:51: bool PdfRenderer::write(const SkString& path) const {
Maybe just pass a stream to this method instead, and then it's up to the caller
whether that stream terminates in a file or just gets dumped?

Seems like it would be cleaner to go through the same code path no matter what
the destination of the stream is...

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp#newc...
tools/render_pdfs_main.cpp:185: ++argv;
indent 4 instead of 2

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp#newc...
tools/render_pdfs_main.cpp:214: parse_commandline(argc, argv, &inputs,
&outputDir);
I think it would be safer to pass outputDir by reference... that way, you don't
have to worry about the caller passing NULL or the wrong party freeing a
pointer.

[edisonn, 2013-01-11 20:12:20]

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp#newc...
tools/render_pdfs_main.cpp:214: parse_commandline(argc, argv, &inputs,
&outputDir);
One usual conventions for readability it is to pass a const reference for [in]
args and a pointer for [out] args

On 2013/01/11 20:00:17, epoger wrote:
> I think it would be safer to pass outputDir by reference... that way, you
don't
> have to worry about the caller passing NULL or the wrong party freeing a
> pointer.

[edisonn, 2013-01-11 20:23:42]

https://codereview.appspot.com/7097045/diff/1/tools/PdfRenderer.cpp
File tools/PdfRenderer.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/PdfRenderer.cpp#newcode51
tools/PdfRenderer.cpp:51: bool PdfRenderer::write(const SkString& path) const {
On 2013/01/11 20:00:17, epoger wrote:
> Maybe just pass a stream to this method instead, and then it's up to the
caller
> whether that stream terminates in a file or just gets dumped?
> 
> Seems like it would be cleaner to go through the same code path no matter what
> the destination of the stream is...

Done.

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp#newc...
tools/render_pdfs_main.cpp:185: ++argv;
On 2013/01/11 20:00:17, epoger wrote:
> indent 4 instead of 2

Done.

[epoger, 2013-01-11 20:26:42]

LGTM!

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.appspot.com/7097045/diff/1/tools/render_pdfs_main.cpp#newc...
tools/render_pdfs_main.cpp:214: parse_commandline(argc, argv, &inputs,
&outputDir);
On 2013/01/11 20:12:20, edisonn wrote:
> One usual conventions for readability it is to pass a const reference for [in]
> args and a pointer for [out] args
> 
> On 2013/01/11 20:00:17, epoger wrote:
> > I think it would be safer to pass outputDir by reference... that way, you
> don't
> > have to worry about the caller passing NULL or the wrong party freeing a
> > pointer.
> 

Indeed, looking at the "Function Parameters" section of
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
I see exactly that guidance.  So please disregard my suggestion.

C++ programmers, always wanting to perform without a net... sigh...