Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 7096063: code review 7096063: libgo/runtime: make sure variables are only defined in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by minux1
Modified:
12 years, 2 months ago
Reviewers:
iant
CC:
gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

libgo/runtime: make sure variables are only defined in one translation unit.

Patch Set 1 #

Patch Set 2 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M libgo/runtime/malloc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/malloc.goc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M libgo/runtime/proc.c View 1 2 chunks +5 lines, -0 lines 0 comments Download
M libgo/runtime/runtime.h View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
minux1
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend/
12 years, 2 months ago (2013-01-20 16:35:15 UTC) #1
minux1
bootstrapped and tested on x86_64-unknown-linux-gnu. This is mainly for Darwin where -fno-common is the default ...
12 years, 2 months ago (2013-01-20 16:52:52 UTC) #2
iant
Can we make the corresponding changes in the gc library?
12 years, 2 months ago (2013-01-20 18:30:24 UTC) #3
minux1
On Monday, January 21, 2013, wrote: > Can we make the corresponding changes in the ...
12 years, 2 months ago (2013-01-21 00:34:04 UTC) #4
iant
The script is libgo/merge.sh. The files in the runtime variable are merged over in the ...
12 years, 2 months ago (2013-01-21 03:55:27 UTC) #5
minux1
12 years, 2 months ago (2013-01-21 04:50:39 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b