Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1897)

Issue 7094054: Change SkAutoTUnref usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by robertphillips
Modified:
11 years, 11 months ago
Reviewers:
Humper, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I believe this is what you had intended. Before the SkData was exiting the if block with 2 refs (ostream & stream). In the new version it exits with 3 refs (+data). Nothing bad happened in the prior version (since the SkData was preserved by the ostream's ref) but I think this is better.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M debugger/SkObjectParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
robertphillips
11 years, 11 months ago (2013-01-14 13:37:39 UTC) #1
Humper
On 2013/01/14 13:37:39, robertphillips wrote: Yeah, this looks better. I admit I'm still not 100% ...
11 years, 11 months ago (2013-01-14 15:17:59 UTC) #2
bsalomon
On 2013/01/14 15:17:59, Humper wrote: > On 2013/01/14 13:37:39, robertphillips wrote: > > Yeah, this ...
11 years, 11 months ago (2013-01-14 15:28:41 UTC) #3
reed1
or SkAutoTUnref<Foo> foo(new Foo); ... Now the allocated foo will get cleaned up when 'foo' ...
11 years, 11 months ago (2013-01-14 15:29:56 UTC) #4
robertphillips
11 years, 11 months ago (2013-01-14 17:40:50 UTC) #5
Message was sent while issue was closed.
committed as r7155
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b