Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(758)

Issue 7092061: Wrap GrEffects in GrEffectPtr. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by bsalomon
Modified:
11 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Wrap GrEffects in GrEffectPtr. This is the first step towards automatic recycling of scratch resouces in the cache via ref-cnts. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7222

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -354 lines) Patch
M gm/texdata.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkColorFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkImageFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +7 lines, -7 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrEffect.h View 1 2 chunks +62 lines, -2 lines 1 comment Download
M include/gpu/GrEffectStage.h View 6 chunks +28 lines, -21 lines 0 comments Download
M include/gpu/GrEffectUnitTest.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 3 chunks +9 lines, -2 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +13 lines, -8 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +25 lines, -10 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 10 chunks +49 lines, -26 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 5 chunks +43 lines, -27 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 4 chunks +47 lines, -28 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 5 chunks +15 lines, -9 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 4 chunks +13 lines, -8 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 4 chunks +18 lines, -10 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 5 chunks +18 lines, -11 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 4 chunks +15 lines, -10 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 5 chunks +21 lines, -13 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 5 chunks +21 lines, -13 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 2 chunks +22 lines, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 12 chunks +18 lines, -16 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 5 chunks +31 lines, -26 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +26 lines, -5 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 2 chunks +21 lines, -9 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 2 chunks +4 lines, -22 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 3 chunks +17 lines, -11 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2
bsalomon
Lots o' files. But most of the changes are cookie-cutter. The interesting file is GrEffect.
11 years, 5 months ago (2013-01-15 22:39:32 UTC) #1
robertphillips
11 years, 5 months ago (2013-01-16 14:10:31 UTC) #2
LGTM

https://codereview.appspot.com/7092061/diff/2001/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.appspot.com/7092061/diff/2001/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:59: There is no public way to wrap a GrEffect in a
GrEffectPtr. Thus, a factory should be a static
subclasses -> subclass
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b