Issue 7092046: Enable per-tile logging in bench_pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7092046: Enable per-tile logging in bench_pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by EricB

Modified:
11 years, 8 months ago

Reviewers:
epoger, rmistry

CC:
skia-review_googlegroups.com, benchen

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

Enable per-tile logging in bench_pictures - Modify bench_pictures buildstep to translate "key: True" --> "--key" rather than requiring "key: value" --> "--key value" - Add whacky TileArgs helper which includes "timeIndividualTiles: True" Committed: https://code.google.com/p/skia/source/detail?r=7141

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
M	buildbot/slave/skia_slave_scripts/bench_pictures.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/tools/bench_pictures_cfg_helper.py	View	1	4 chunks	+10 lines, -5 lines	0 comments	Download
M	trunk/tools/tests/bench_pictures_cfg_test.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM https://codereview.appspot.com/7092046/diff/2001/trunk/tools/tests/bench_pictures_cfg_test.py File trunk/tools/tests/bench_pictures_cfg_test.py (right): https://codereview.appspot.com/7092046/diff/2001/trunk/tools/tests/bench_pictures_cfg_test.py#newcode42 trunk/tools/tests/bench_pictures_cfg_test.py:42: else: Nit: Use elif not value is True...

11 years, 8 months ago (2013-01-11 20:37:54 UTC) #2

EricB

11 years, 8 months ago (2013-01-11 20:45:32 UTC) #3

Message was sent while issue was closed.

Committed as r7141.

https://codereview.appspot.com/7092046/diff/2001/trunk/tools/tests/bench_pict...
File trunk/tools/tests/bench_pictures_cfg_test.py (right):

https://codereview.appspot.com/7092046/diff/2001/trunk/tools/tests/bench_pict...
trunk/tools/tests/bench_pictures_cfg_test.py:42: else:
On 2013/01/11 20:37:55, rmistry wrote:
> Nit: Use elif not value is True...

Done.

Expand All Messages | Collapse All Messages