Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1505)

Issue 7086053: Fix gyp files when building Android for x86 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by DerekS
Modified:
11 years, 11 months ago
Reviewers:
EricB, gram
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix gyp files when building Android for x86 BUG=606 Committed: https://code.google.com/p/skia/source/detail?r=7271

Patch Set 1 #

Total comments: 5

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gyp/opts.gyp View 2 chunks +5 lines, -3 lines 0 comments Download
M gyp/skia_base_libs.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
DerekS
11 years, 11 months ago (2013-01-14 20:11:41 UTC) #1
EricB
LGTM https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44 gyp/opts.gyp:44: }], This is because x86 Android doesn't support ...
11 years, 11 months ago (2013-01-14 20:21:06 UTC) #2
gram
https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44 gyp/opts.gyp:44: }], On 2013/01/14 20:21:06, EricB wrote: > This is ...
11 years, 11 months ago (2013-01-14 20:40:32 UTC) #3
DerekS
https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44 gyp/opts.gyp:44: }], No, it is because we need to add ...
11 years, 11 months ago (2013-01-14 20:54:29 UTC) #4
gram
BTW I'm in offsite training today so won't be able to test on a physical ...
11 years, 11 months ago (2013-01-14 20:56:37 UTC) #5
gram
11 years, 11 months ago (2013-01-17 19:17:05 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b