Fix gyp files when building Android for x86

Fix gyp files when building Android for x86


BUG=606

Committed: https://code.google.com/p/skia/source/detail?r=7271

[EricB, 2013-01-14 20:21:06]

LGTM

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44
gyp/opts.gyp:44: }],
This is because x86 Android doesn't support ssse3?

[gram, 2013-01-14 20:40:32]

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44
gyp/opts.gyp:44: }],
On 2013/01/14 20:21:06, EricB wrote:
> This is because x86 Android doesn't support ssse3?

The Moto Razr i, which is the only x86 in market right now, has an Atom CPU and
supports SSE2 and SSE3.

https://codereview.appspot.com/7086053/diff/1/gyp/skia_base_libs.gyp
File gyp/skia_base_libs.gyp (right):

https://codereview.appspot.com/7086053/diff/1/gyp/skia_base_libs.gyp#newcode11
gyp/skia_base_libs.gyp:11: [ 'skia_arch_type == "x86" and skia_os not in
["android", "ios"]', {
is ios needed here?

[DerekS, 2013-01-14 20:54:29]

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.appspot.com/7086053/diff/1/gyp/opts.gyp#newcode44
gyp/opts.gyp:44: }],
No, it is because we need to add runtime detection of SSE3 as it is not
guaranteed to be a part of the ABI.  I wanted to get something up and working
before adding in additional optimizations.

On 2013/01/14 20:40:32, gram wrote:
> On 2013/01/14 20:21:06, EricB wrote:
> > This is because x86 Android doesn't support ssse3?
> 
> The Moto Razr i, which is the only x86 in market right now, has an Atom CPU
and
> supports SSE2 and SSE3.

https://codereview.appspot.com/7086053/diff/1/gyp/skia_base_libs.gyp
File gyp/skia_base_libs.gyp (right):

https://codereview.appspot.com/7086053/diff/1/gyp/skia_base_libs.gyp#newcode11
gyp/skia_base_libs.gyp:11: [ 'skia_arch_type == "x86" and skia_os not in
["android", "ios"]', {
nope, we don't want to build this for ios, but having it here is overkill since
there are no x86 ios devices.

On 2013/01/14 20:40:32, gram wrote:
> is ios needed here?

[gram, 2013-01-14 20:56:37]

BTW I'm in offsite training today so won't be able to test on a physical
device until tomorrow. but Vijay Menon may have a chance today.


On Mon, Jan 14, 2013 at 12:54 PM, <djsollen@google.com> wrote:

>
>
https://codereview.appspot.**com/7086053/diff/1/gyp/opts.**gyp<https://codere...
> File gyp/opts.gyp (right):
>
>
https://codereview.appspot.**com/7086053/diff/1/gyp/opts.**gyp#newcode44<http...
> gyp/opts.gyp:44: }],
> No, it is because we need to add runtime detection of SSE3 as it is not
> guaranteed to be a part of the ABI.  I wanted to get something up and
> working before adding in additional optimizations.
>
>
> On 2013/01/14 20:40:32, gram wrote:
>
>> On 2013/01/14 20:21:06, EricB wrote:
>> > This is because x86 Android doesn't support ssse3?
>>
>
>  The Moto Razr i, which is the only x86 in market right now, has an
>>
> Atom CPU and
>
>> supports SSE2 and SSE3.
>>
>
>
https://codereview.appspot.**com/7086053/diff/1/gyp/skia_**base_libs.gyp<http...
> File gyp/skia_base_libs.gyp (right):
>
> https://codereview.appspot.**com/7086053/diff/1/gyp/skia_**
>
base_libs.gyp#newcode11<https://codereview.appspot.com/7086053/diff/1/gyp/skia_base_libs.gyp#newcode11>
> gyp/skia_base_libs.gyp:11: [ 'skia_arch_type == "x86" and skia_os not in
> ["android", "ios"]', {
> nope, we don't want to build this for ios, but having it here is
> overkill since there are no x86 ios devices.
>
>
> On 2013/01/14 20:40:32, gram wrote:
>
>> is ios needed here?
>>
>
>
https://codereview.appspot.**com/7086053/<https://codereview.appspot.com/7086...
>

[gram, 2013-01-17 19:17:05]

lgtm