Issue 7086051: Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7086051: Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader. Committed: https://code.google.com/p/skia/source/detail?r=7153

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -188 lines)			Patch
M	gyp/core.gyp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	include/core/SkShader.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/core/SkBitmapProcShader.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapProcShader.cpp	View	1 2 3	1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/core/SkShader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkLinearGradient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkLinearGradient.cpp	View	1 2 3 4	2 chunks	+6 lines, -11 lines	0 comments	Download
M	src/effects/gradients/SkRadialGradient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkRadialGradient.cpp	View	1 2 3 4	3 chunks	+6 lines, -11 lines	0 comments	Download
M	src/effects/gradients/SkSweepGradient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkSweepGradient.cpp	View	1 2 3 4	2 chunks	+6 lines, -11 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1 2 3 4	3 chunks	+6 lines, -13 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	1 2 3 4	4 chunks	+7 lines, -13 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	12 chunks	+30 lines, -119 lines	0 comments	Download

Total messages: 2

bsalomon

This overdue cleanup removes a small obstacle to the effect-wrapper change.

11 years, 5 months ago (2013-01-14 16:29:08 UTC) #1

LGTM