Issue 7075043: Proposed fix to new stroking/path render selection system

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7075043: Proposed fix to new stroking/path render selection system (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by robertphillips

Modified:
11 years, 10 months ago

Reviewers:
sugoi1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Proposed fix to new stroking/path render selection system

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -15 lines)			Patch
	M	src/gpu/GrContext.cpp	View		2 chunks	+24 lines, -15 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

I believe this fixes the Xoom errors. The only change from Alexis' original CL is ...

11 years, 10 months ago (2013-01-07 23:57:10 UTC) #1

sugoi1

https://codereview.appspot.com/7075043/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.appspot.com/7075043/diff/1/src/gpu/GrContext.cpp#newcode1119 src/gpu/GrContext.cpp:1119: pr = this->getPathRenderer(*pathPtr, strokeRec, target, true, type); Ah, it ...

11 years, 10 months ago (2013-01-08 13:40:58 UTC) #3

Message was sent while issue was closed.

committed as r7076

Expand All Messages | Collapse All Messages