Issue 7071056: Build fix.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7071056: Build fix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by Zhenyao Mo

Modified:
11 years, 8 months ago

Reviewers:
apatrick

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Build fix. BUG= TEST=build fine in Linux Committed: https://code.google.com/p/angleproject/source/detail?r=1645

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/OutputGLSLBase.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick

11 years, 8 months ago (2013-01-08 23:16:18 UTC) #2

LGTM


On Tue, Jan 8, 2013 at 3:07 PM, <zmo@chromium.org> wrote:

> Reviewers: apatrick,
>
> Message:
> PTAL
>
> FLT_MAX is not defined in <limits> but <cfloat>
>
> Description:
> Build fix.
>
> BUG=
> TEST=build fine in Linux
>
> Please review this at
https://codereview.appspot.**com/7071056/<https://codereview.appspot.com/7071...
>
> Affected files:
>   M     src/common/version.h
>   M     src/compiler/OutputGLSLBase.**cpp
>
>
> Index: src/common/version.h
> ==============================**==============================**=======
> --- src/common/version.h        (revision 1644)
> +++ src/common/version.h        (working copy)
> @@ -1,7 +1,7 @@
>  #define MAJOR_VERSION 1
>  #define MINOR_VERSION 0
>  #define BUILD_VERSION 0
> -#define BUILD_REVISION 1644
> +#define BUILD_REVISION 1645
>
>  #define STRINGIFY(x) #x
>  #define MACRO_STRINGIFY(x) STRINGIFY(x)
> Index: src/compiler/OutputGLSLBase.**cpp
> ==============================**==============================**=======
> --- src/compiler/OutputGLSLBase.**cpp     (revision 1644)
> +++ src/compiler/OutputGLSLBase.**cpp     (working copy)
> @@ -7,7 +7,7 @@
>  #include "compiler/OutputGLSLBase.h"
>  #include "compiler/debug.h"
>
> -#include <limits.h>
> +#include <cfloat>
>
>  namespace
>  {
>
>
>

Expand All Messages | Collapse All Messages