Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1653)

Issue 7070066: gm: if no readPath is given, report all tests as "missing reference image" instead of "passed" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by epoger
Modified:
11 years, 10 months ago
Reviewers:
EricB, rmistry
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

gm: if no readPath is given, report all tests as "missing reference image" instead of "passed" Committed: https://code.google.com/p/skia/source/detail?r=7119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gm/gmmain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
epoger
first LG wins... The JSON summary file already reports these results as "no-comparison" instead of ...
11 years, 10 months ago (2013-01-10 17:05:18 UTC) #1
epoger
11 years, 10 months ago (2013-01-10 17:05:32 UTC) #2
EricB
11 years, 10 months ago (2013-01-10 17:10:56 UTC) #3
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b