Done https://codereview.appspot.com/7069060/diff/8001/src/run.rc File src/run.rc (right): https://codereview.appspot.com/7069060/diff/8001/src/run.rc#newcode8 src/run.rc:8: export GOTRACEBACK=2 What should I use here: set ...
11 years, 3 months ago
(2013-01-09 09:58:49 UTC)
#3
Please revert this CL and try this instead (gmail threw away my tabs but you ...
11 years, 3 months ago
(2013-01-09 19:52:27 UTC)
#7
Please revert this CL and try this instead (gmail threw away my tabs
but you should be able to read it):
diff -r 7314824cf6b8 src/pkg/runtime/panic.c
--- a/src/pkg/runtime/panic.c Sun Jan 06 22:44:16 2013 -0500
+++ b/src/pkg/runtime/panic.c Wed Jan 09 14:51:43 2013 -0500
@@ -454,6 +454,7 @@
void
runtime·throw(int8 *s)
{
+ runtime·throwing = 1;
runtime·startpanic();
runtime·printf("fatal error: %s\n", s);
runtime·dopanic(0);
diff -r 7314824cf6b8 src/pkg/runtime/symtab.c
--- a/src/pkg/runtime/symtab.c Sun Jan 06 22:44:16 2013 -0500
+++ b/src/pkg/runtime/symtab.c Wed Jan 09 14:51:43 2013 -0500
@@ -563,6 +563,8 @@
{
static int32 traceback = -1;
+ if(runtime·throwing)
+ return 1;
if(traceback < 0)
traceback = runtime·gotraceback();
return traceback > 1 || contains(f->name, ".") &&
!hasprefix(f->name, "runtime.");
If it works, please send it out.
This will have the benefit of showing the frames even outside of all.bash.
Russ
Issue 7069060: code review 7069060: run.bash: set GOTRACEBACK=2
(Closed)
Created 11 years, 3 months ago by dvyukov
Modified 11 years, 3 months ago
Reviewers: golang-dev, minux1, rsc
Base URL:
Comments: 2