Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 7069060: code review 7069060: run.bash: set GOTRACEBACK=2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by dvyukov
Modified:
9 years, 5 months ago
Reviewers:
minux1, rsc, golang-dev
Visibility:
Public.

Description

run.bash: set GOTRACEBACK=2 This is useful to debug episodic crashes.

Patch Set 1 #

Patch Set 2 : diff -r 1399878c6731 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 1399878c6731 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 1399878c6731 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 1399878c6731 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 1399878c6731 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/run.bash View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/run.bat View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/run.rc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 5 months ago (2013-01-09 07:21:25 UTC) #1
minux1
consider also update run.rc? changes to run.bash and run.bat LGTM.
9 years, 5 months ago (2013-01-09 09:42:03 UTC) #2
dvyukov
Done https://codereview.appspot.com/7069060/diff/8001/src/run.rc File src/run.rc (right): https://codereview.appspot.com/7069060/diff/8001/src/run.rc#newcode8 src/run.rc:8: export GOTRACEBACK=2 What should I use here: set ...
9 years, 5 months ago (2013-01-09 09:58:49 UTC) #3
ality
dvyukov@google.com once said: > https://codereview.appspot.com/7069060/diff/8001/src/run.rc > File src/run.rc (right): > > https://codereview.appspot.com/7069060/diff/8001/src/run.rc#newcode8 > src/run.rc:8: export ...
9 years, 5 months ago (2013-01-09 10:13:59 UTC) #4
minux1
I just take a look at run.rc, and I think there are other problems. (for ...
9 years, 5 months ago (2013-01-09 10:16:13 UTC) #5
dvyukov
On 2013/01/09 10:13:59, ality wrote: > mailto:dvyukov@google.com once said: > > https://codereview.appspot.com/7069060/diff/8001/src/run.rc > > File ...
9 years, 5 months ago (2013-01-09 10:17:18 UTC) #6
rsc
Please revert this CL and try this instead (gmail threw away my tabs but you ...
9 years, 5 months ago (2013-01-09 19:52:27 UTC) #7
dvyukov
9 years, 5 months ago (2013-01-12 13:46:39 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b