Mike- thanks for rebaselining the gm self-tests in https://code.google.com/p/skia/source/detail?r=6995 . But there was a problem ...
11 years, 8 months ago
(2013-01-10 15:56:12 UTC)
#1
Mike- thanks for rebaselining the gm self-tests in
https://code.google.com/p/skia/source/detail?r=6995 .
But there was a problem that rebaseline.sh didn't take care of for you...
Because your prior change (https://code.google.com/p/skia/source/detail?r=6984)
affected the expected dashing2.png output, the "golden master" images in these
directories needed to be updated:
- tests/inputs/identical-bytes: exact copy of the new dashing2.png
- tests/inputs/identical-pixels: a PNG file with different bytes but the same
pixels (which I currently create by hand using gimp)
This is a weakness in rebaseline.sh, which I had previously used to rebaseline
after changes to *gm*, not changes to *the rendering code*. At some point we
should look into improving this part of the tool's behavior.
But for now, here's a manual fix.
On 2013/01/10 16:19:17, reed1 wrote: > lgtm > > do we expect to face this ...
11 years, 8 months ago
(2013-01-10 16:23:28 UTC)
#4
Message was sent while issue was closed.
On 2013/01/10 16:19:17, reed1 wrote:
> lgtm
>
> do we expect to face this everytime we make a skia change that affects
dashing2?
Unfortunately yes... to the extent that we want a continuously running gm
self-test, we will run into this in some form. We *could* create a
pathologically simple gm test (just renders a rectangle?) whose output would
almost never change... do you think that would be a good idea?
Issue 7068060: gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior
(Closed)
Created 11 years, 8 months ago by epoger
Modified 11 years, 8 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0