Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 7068060: gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by epoger
Modified:
11 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior TBR=reed1 Committed: https://code.google.com/p/skia/source/detail?r=7116

Patch Set 1 #

Messages

Total messages: 4
epoger
Mike- thanks for rebaselining the gm self-tests in https://code.google.com/p/skia/source/detail?r=6995 . But there was a problem ...
11 years, 8 months ago (2013-01-10 15:56:12 UTC) #1
epoger
Filed https://code.google.com/p/skia/issues/detail?id=1049 ('make gm/tests/rebaseline.sh update input images when rendering code changes') to track resolution
11 years, 8 months ago (2013-01-10 16:00:32 UTC) #2
reed1
lgtm do we expect to face this everytime we make a skia change that affects ...
11 years, 8 months ago (2013-01-10 16:19:17 UTC) #3
epoger
11 years, 8 months ago (2013-01-10 16:23:28 UTC) #4
Message was sent while issue was closed.
On 2013/01/10 16:19:17, reed1 wrote:
> lgtm
> 
> do we expect to face this everytime we make a skia change that affects
dashing2?

Unfortunately yes... to the extent that we want a continuously running gm
self-test, we will run into this in some form.  We *could* create a
pathologically simple gm test (just renders a rectangle?) whose output would
almost never change... do you think that would be a good idea?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b