Issue 7068058: Add D3D version and shader models to renderer string reported by GetString.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7068058: Add D3D version and shader models to renderer string reported by GetString. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by apatrick1

Modified:
11 years, 4 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add D3D version and shader models to renderer string reported by GetString. It looks like this now: ANGLE (NVIDIA Quadro 600 Direct3D9Ex vs_3_0 ps_3_0) I also noticed that the strings returned by GetString are not all static so I fixed that as well. Committed: https://code.google.com/p/angleproject/source/detail?r=1646

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -37 lines)			Patch
	M	src/libGLESv2/Context.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/libGLESv2/Context.cpp	View	1	4 chunks	+66 lines, -35 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dgkoch

11 years, 4 months ago (2013-01-10 00:49:53 UTC) #1

LGTM

https://codereview.appspot.com/7068058/diff/4/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

https://codereview.appspot.com/7068058/diff/4/src/libGLESv2/Context.cpp#newco...
src/libGLESv2/Context.cpp:4023: rendererString << " vs_" <<
D3DSHADER_VERSION_MAJOR(mDeviceCaps.VertexShaderVersion) << "_" <<
D3DSHADER_VERSION_MINOR(mDeviceCaps.VertexShaderVersion);
I'm going to have to change this somewhat when I merge this to the branch since
we no longer use the mDeviceCaps in Context.  Shouldn't be a major issue though.

Expand All Messages | Collapse All Messages