eliminate all warnings in non-thirdparty code on mac

eliminate all warnings in non-thirdparty code on mac

Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.

Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.

Lots of unused variables removed, and one nasty const issue handled.

There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch.  I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.

BUG=

Committed: https://code.google.com/p/skia/source/detail?r=7051

[reed1, 2013-01-07 14:44:10]

lgtm for non gpu files

[bsalomon, 2013-01-07 14:47:02]

lgtm modulo turning a couple comment-outs into deletions.

I cannot believe we still have GrTDArray. I will try to make time today to
expunge it.

https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp#n...
src/gpu/GrClipMaskManager.cpp:265: #if 0
Let's just delete it.

https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp#newcode...
src/gpu/SkGpuDevice.cpp:1342: // GrEffectStage* stage =
grPaint->colorStage(kBitmapTextureIdx);
Yeah, it's ok. We can just delete the line w/ the unused var.

[Humper, 2013-01-07 15:16:24]

On 2013/01/07 14:47:02, bsalomon wrote:
> lgtm modulo turning a couple comment-outs into deletions.
> 
> I cannot believe we still have GrTDArray. I will try to make time today to
> expunge it.
> 
> https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp#n...
> src/gpu/GrClipMaskManager.cpp:265: #if 0
> Let's just delete it.
> 
> https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp
> File src/gpu/SkGpuDevice.cpp (right):
> 
>
https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp#newcode...
> src/gpu/SkGpuDevice.cpp:1342: // GrEffectStage* stage =
> grPaint->colorStage(kBitmapTextureIdx);
> Yeah, it's ok. We can just delete the line w/ the unused var.

Okay, I'll change all commented out things to deleted things.  I just wanted to
make sure that I wasn't blowing away something that might be called at some
later date.

[bsalomon, 2013-01-07 15:17:31]

On 2013/01/07 15:16:24, Humper wrote:
> On 2013/01/07 14:47:02, bsalomon wrote:
> > lgtm modulo turning a couple comment-outs into deletions.
> > 
> > I cannot believe we still have GrTDArray. I will try to make time today to
> > expunge it.
> > 
> > https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp
> > File src/gpu/GrClipMaskManager.cpp (right):
> > 
> >
>
https://codereview.appspot.com/7067044/diff/1/src/gpu/GrClipMaskManager.cpp#n...
> > src/gpu/GrClipMaskManager.cpp:265: #if 0
> > Let's just delete it.
> > 
> > https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp
> > File src/gpu/SkGpuDevice.cpp (right):
> > 
> >
>
https://codereview.appspot.com/7067044/diff/1/src/gpu/SkGpuDevice.cpp#newcode...
> > src/gpu/SkGpuDevice.cpp:1342: // GrEffectStage* stage =
> > grPaint->colorStage(kBitmapTextureIdx);
> > Yeah, it's ok. We can just delete the line w/ the unused var.
> 
> Okay, I'll change all commented out things to deleted things.  I just wanted
to
> make sure that I wasn't blowing away something that might be called at some
> later date.

Great, thanks for checking first.

[bsalomon, 2013-01-07 16:47:48]

On 2013/01/07 16:46:24, Humper wrote:

lgtm