Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 7066068: Set siginfo.si_pid to getpid() in SimulateSignalDelivery()

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by glider1
Modified:
11 years, 11 months ago
Base URL:
svn://svn.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

ExceptionHandler::HandleSignal (https://code.google.com/searchframe#OAMlx_jo-ck/src/breakpad/src/client/linux/handler/exception_handler.cc&exact_package=chromium&q=SI_USER&type=cs&l=389) requires si_pid to be equal to getpid() for SI_USER signals. This is a patch by Lei Zhang (thestig@chromium.org) that fixes the issue with Chrome+ASan being unable to upload the crash dump to the crash server when the seccomp sandbox is on.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M breakpad/src/client/linux/handler/exception_handler.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8
glider1
PTAL
11 years, 11 months ago (2013-01-10 08:57:10 UTC) #1
thestig
On 2013/01/10 08:57:10, glider1 wrote: > PTAL Deferring to Mark since this is what I ...
11 years, 11 months ago (2013-01-10 23:33:42 UTC) #2
Mark Mentovai
https://codereview.appspot.com/7066068/diff/1/breakpad/src/client/linux/handler/exception_handler.cc File breakpad/src/client/linux/handler/exception_handler.cc (right): https://codereview.appspot.com/7066068/diff/1/breakpad/src/client/linux/handler/exception_handler.cc#newcode419 breakpad/src/client/linux/handler/exception_handler.cc:419: siginfo.si_code = SI_USER; Comment-worthy.
11 years, 11 months ago (2013-01-14 17:33:22 UTC) #3
glider1
https://codereview.appspot.com/7066068/diff/1/breakpad/src/client/linux/handler/exception_handler.cc File breakpad/src/client/linux/handler/exception_handler.cc (right): https://codereview.appspot.com/7066068/diff/1/breakpad/src/client/linux/handler/exception_handler.cc#newcode419 breakpad/src/client/linux/handler/exception_handler.cc:419: siginfo.si_code = SI_USER; On 2013/01/14 17:33:22, Mark Mentovai wrote: ...
11 years, 11 months ago (2013-01-14 18:02:11 UTC) #4
Mark Mentovai
LGTM
11 years, 11 months ago (2013-01-14 18:03:14 UTC) #5
glider1
On 2013/01/14 18:03:14, Mark Mentovai wrote: > LGTM Can you please also land this?
11 years, 11 months ago (2013-01-14 18:07:39 UTC) #6
Mark Mentovai
Committed Breakpad r1095
11 years, 11 months ago (2013-01-14 18:53:27 UTC) #7
glider
11 years, 11 months ago (2013-01-14 18:56:03 UTC) #8
Thanks a lot!
On Jan 14, 2013 10:53 PM, <mark@chromium.org> wrote:

> Committed Breakpad r1095
>
>
https://codereview.appspot.**com/7066068/<https://codereview.appspot.com/7066...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b