Issue 7066051: fix warnings (float to int), and convert to skia-style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7066051: fix warnings (float to int), and convert to skia-style (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by reed1

Modified:
11 years, 11 months ago

Reviewers:
Humper

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

fix warnings (float to int), and convert to skia-style style examples: - use const: (const SkRect&) instead of (SkRect&) - spacing: (Type& r) instead of ( Type &r ) - use SK_OVERRIDE Committed: https://code.google.com/p/skia/source/detail?r=7069

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -21 lines)			Patch
	M	bench/BlurRectBench.cpp	View	1 2 3 4	7 chunks	+24 lines, -21 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages