Show the paint's typeface information in the details pane of the debugger.

Show the paint's typeface information in the details pane of the debugger.

Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Committed: https://code.google.com/p/skia/source/detail?r=7048

[Humper, 2013-01-05 01:36:59]

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp#new...
debugger/SkObjectParser.cpp:104: SkString* mPaint = new
SkString("<dl><dt>SkPaint:</dt><dd><dl><dt>Color:</dt><dd>0x");
Since the details pane is a QT html viewer, formatting the paint as a <dl> makes
it actually legible :)

[DerekS, 2013-01-07 13:54:09]

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp#new...
debugger/SkObjectParser.cpp:106: mPaint->append( "</dd>" );
To keep with the coding style in Skia we don't put spaces at the beginning or
end of parenthesis.

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp#new...
debugger/SkObjectParser.cpp:112: SkData *data = ostream.copyToData();
you will need to unref the data object in order not to leak it.  You can do that
in a couple different ways.

1) call unref() on the object directly
2) use SkSafeUnref(T*) to prevent crashes if the ptr is null
3) use SkAutoTUnref or other helper class in SkRefCnt.h

https://codereview.appspot.com/7065045/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.appspot.com/7065045/diff/1/src/core/SkStream.cpp#newcode303
src/core/SkStream.cpp:303: fData = SkData::NewEmpty();
instead of paying the price of an extra function call and a potential malloc in
SkData::NewEmpty() you can just have:

fData = SkSafeRef(data);
fOffset = 0;

[Humper, 2013-01-07 15:27:17]

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp
File debugger/SkObjectParser.cpp (right):

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp#new...
debugger/SkObjectParser.cpp:106: mPaint->append( "</dd>" );
On 2013/01/07 13:54:10, DerekS wrote:
> To keep with the coding style in Skia we don't put spaces at the beginning or
> end of parenthesis.

Ah, okay.  That's going to take some finger retraining :)

https://codereview.appspot.com/7065045/diff/1/debugger/SkObjectParser.cpp#new...
debugger/SkObjectParser.cpp:112: SkData *data = ostream.copyToData();
On 2013/01/07 13:54:10, DerekS wrote:
> you will need to unref the data object in order not to leak it.  You can do
that
> in a couple different ways.
> 
> 1) call unref() on the object directly
> 2) use SkSafeUnref(T*) to prevent crashes if the ptr is null
> 3) use SkAutoTUnref or other helper class in SkRefCnt.h

Thanks, stuff like this is probably more valuable for me to know than even the
paint's font name :)

[reed1, 2013-01-07 15:37:49]

https://codereview.appspot.com/7065045/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.appspot.com/7065045/diff/1/src/core/SkStream.cpp#newcode303
src/core/SkStream.cpp:303: fData = SkData::NewEmpty();
On 2013/01/07 13:54:10, DerekS wrote:
> instead of paying the price of an extra function call and a potential malloc
in
> SkData::NewEmpty() you can just have:
> 
> fData = SkSafeRef(data);
> fOffset = 0;

+1

[DerekS, 2013-01-07 15:42:13]

lgtm if the spacing style is updated.