Issue 7063050: Fix macro redefinition warning on 10.6 bots in mesa code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7063050: Fix macro redefinition warning on 10.6 bots in mesa code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
Humper

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix macro redefinition warning on 10.6 bots in mesa code. R=humper@google.com Committed: https://code.google.com/p/skia/source/detail?r=7086

Patch Set 4 : #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	A	src/gpu/gl/mesa/osmesa_wrapper.h	View	1 2 3	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Humper

https://codereview.appspot.com/7063050/diff/5001/src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp File src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp (right): https://codereview.appspot.com/7063050/diff/5001/src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp#newcode17 src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp:17: // selectively disable this warning. Are you sure this ...

11 years, 5 months ago (2013-01-08 15:50:07 UTC) #2

bsalomon

11 years, 5 months ago (2013-01-08 15:53:39 UTC) #3

Humper

11 years, 5 months ago (2013-01-08 16:31:36 UTC) #5

On 2013/01/08 16:27:52, bsalomon wrote:
> New approach.

That we have to do this makes me sad, but I like the new approach.

lgtm

Expand All Messages | Collapse All Messages