Issue 7062063: Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7062063: Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs. Committed: https://code.google.com/p/skia/source/detail?r=7129

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -71 lines)			Patch
M	include/gpu/GrEffect.h	View	1	3 chunks	+17 lines, -14 lines	1 comment	Download
M	src/effects/SkBlendImageFilter.cpp	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View		3 chunks	+2 lines, -9 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrEffect.cpp	View		3 chunks	+2 lines, -10 lines	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.cpp	View		1 chunk	+12 lines, -17 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

This adds the hook that will allow us to ref the textures as an effect ...

11 years, 5 months ago (2013-01-10 21:46:30 UTC) #1

robertphillips

11 years, 5 months ago (2013-01-11 13:11:05 UTC) #2

LGTM

https://codereview.appspot.com/7062063/diff/2001/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.appspot.com/7062063/diff/2001/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:99: * manages the lifetime of the accesses (this function
only stores a pointer). This must only be
rm second only?

Expand All Messages | Collapse All Messages