Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1984)

Issue 7062063: Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by bsalomon
Modified:
11 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs. Committed: https://code.google.com/p/skia/source/detail?r=7129

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -71 lines) Patch
M include/gpu/GrEffect.h View 1 3 chunks +17 lines, -14 lines 1 comment Download
M src/effects/SkBlendImageFilter.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +2 lines, -9 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrEffect.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 1 chunk +12 lines, -17 lines 0 comments Download

Messages

Total messages: 2
bsalomon
This adds the hook that will allow us to ref the textures as an effect ...
11 years, 10 months ago (2013-01-10 21:46:30 UTC) #1
robertphillips
11 years, 10 months ago (2013-01-11 13:11:05 UTC) #2
LGTM

https://codereview.appspot.com/7062063/diff/2001/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.appspot.com/7062063/diff/2001/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:99: * manages the lifetime of the accesses (this function
only stores a pointer). This must only be
rm second only?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b