Issue 7062054: pass modifier keys to click events (e.g. control

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7062054: pass modifier keys to click events (e.g. control | shift etc.) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by reed1

Modified:
11 years, 10 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pass modifier keys to click events (e.g. control | shift etc.) Committed: https://code.google.com/p/skia/source/detail?r=7082

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -87 lines)			Patch
M	include/views/SkKey.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	include/views/SkOSWindow_Mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/views/SkOSWindow_iOS.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/views/SkView.h	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	include/views/SkWindow.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleAll.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleApp.h	View		1 chunk	+15 lines, -13 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View		5 chunks	+59 lines, -5 lines	0 comments	Download
M	samplecode/SampleArc.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleCode.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	samplecode/SampleConcavePaths.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleEncode.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleHairline.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleLayers.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SamplePatch.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SamplePath.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleRepeatTile.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	samplecode/SampleRotateCircles.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleShaders.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleStrokePath.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleText.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	samplecode/SampleTextOnPath.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/views/SkView.cpp	View		7 chunks	+12 lines, -10 lines	0 comments	Download
M	src/views/SkWindow.cpp	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/views/mac/SkNSView.mm	View		1 chunk	+37 lines, -4 lines	0 comments	Download
M	src/views/mac/SkOSWindow_Mac.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/views/unix/SkOSWindow_Unix.cpp	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2013/01/08 15:41:42, reed1 wrote: No love for linux or windows?

11 years, 10 months ago (2013-01-08 15:47:12 UTC) #2

reed1

they get love when I can see what doesn't compile there. all in good time...

11 years, 10 months ago (2013-01-08 16:03:01 UTC) #3

bsalomon

11 years, 10 months ago (2013-01-08 16:10:30 UTC) #4

On 2013/01/08 16:03:01, reed1 wrote:
> they get love when I can see what doesn't compile there. all in good time...

lgtm

Expand All Messages | Collapse All Messages