Issue 7061044: Upodate preprocessor.vcxproj to reflect changes in r1640.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7061044: Upodate preprocessor.vcxproj to reflect changes in r1640. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by apatrick1

Modified:
11 years, 4 months ago

Reviewers:
kbr1, mvujovic

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Upodate preprocessor.vcxproj to reflect changes in r1640. Committed: https://code.google.com/p/angleproject/source/detail?r=1642

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/compiler/preprocessor/preprocessor.vcxproj	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kbr1

LGTM; sorry I missed that. Should the build version be incremented too?

11 years, 4 months ago (2013-01-04 21:48:56 UTC) #2

mvujovic

On 2013/01/04 21:48:56, kbr1 wrote: > LGTM; sorry I missed that. Should the build version ...

11 years, 4 months ago (2013-01-08 00:22:47 UTC) #3

kbr1

On 2013/01/08 00:22:47, mvujovic wrote: > On 2013/01/04 21:48:56, kbr1 wrote: > > LGTM; sorry ...

11 years, 4 months ago (2013-01-08 00:29:44 UTC) #4

mvujovic

11 years, 4 months ago (2013-01-08 01:07:37 UTC) #5

Message was sent while issue was closed.

On 2013/01/08 00:29:44, kbr1 wrote:
> On 2013/01/08 00:22:47, mvujovic wrote:
> > On 2013/01/04 21:48:56, kbr1 wrote:
> > > LGTM; sorry I missed that. Should the build version be incremented too?
> > 
> > Sorry! Forgot to update in Visual Studio. Thanks.
> > 
> > What is the policy on updating the build version? (When should it be done?)
> 
> Basically it should be done on every commit.

Ok. I'll do that from now on.

Expand All Messages | Collapse All Messages