Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1965)

Issue 7060071: Changing imageFilterTests to use drawBitmap instead of drawSprite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by junov1
Modified:
11 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Changing imageFilter GM tests to use drawBitmap instead of drawSprite The motivation is be able to test the filters with scaled SkPicture playback in isolation from the issues that surround usage of drawSprite Committed: https://code.google.com/p/skia/source/detail?r=7152

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M gm/blend.cpp View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download
M gm/gm.h View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M gm/gmmain.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M gm/imagefiltersbase.cpp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M gm/lighting.cpp View 1 2 3 2 chunks +14 lines, -6 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
junov
11 years, 11 months ago (2013-01-10 21:57:16 UTC) #1
Stephen White
Thanks for doing this. https://codereview.appspot.com/7060071/diff/3001/gm/blend.cpp File gm/blend.cpp (right): https://codereview.appspot.com/7060071/diff/3001/gm/blend.cpp#newcode66 gm/blend.cpp:66: void drawBlendedBitmap(SkCanvas* canvas, const SkPaint& ...
11 years, 11 months ago (2013-01-10 22:20:47 UTC) #2
junov
Done. And I added and exclusion flag to exclude imagefiltersbase from scaled playback since it ...
11 years, 11 months ago (2013-01-14 15:49:22 UTC) #3
Stephen White
11 years, 11 months ago (2013-01-14 16:22:30 UTC) #4
On 2013/01/14 15:49:22, junov wrote:
> Done.  
> And I added and exclusion flag to exclude imagefiltersbase from scaled
playback
> since it was deliberately designed to cover drawSprite.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b