Issue 7060043: Fix the computed (new) inverse matrix when we detect that a shader's matrix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7060043: Fix the computed (new) inverse matrix when we detect that a shader's matrix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by reed1

Modified:
11 years, 10 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix the computed (new) inverse matrix when we detect that a shader's matrix can effectively be consider translate-only. Committed: https://code.google.com/p/skia/source/detail?r=7039

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	src/core/SkBitmapProcState.cpp	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

add SK_IGNORE_TRANS_CLAMP_FIX to skia.gyp to suppress changes if needed

11 years, 10 months ago (2013-01-05 14:38:06 UTC) #3

robertphillips

11 years, 10 months ago (2013-01-07 13:29:33 UTC) #4

Message was sent while issue was closed.

Without SK_IGNORE_TRANS_CLAMP_FIX we get the following layout test failures
(please see https://codereview.chromium.org/11801004/):

  fast/borders/border-image-outset-split-inline-vertical-lr.html [
ImageOnlyFailure ]
  fast/borders/border-image-outset-split-inline.html [ ImageOnlyFailure ]
  fast/borders/border-image-slice-constrained.html [ ImageOnlyFailure ]
  fast/writing-mode/border-image-horizontal-bt.html [ ImageOnlyFailure ] -
mac-only?
  fast/writing-mode/border-image-vertical-lr.html [ ImageOnlyFailure ] -
mac-only?
  fast/writing-mode/border-image-vertical-rl.html [ ImageOnlyFailure ] -
mac-only?
  svg/W3C-SVG-1.1/coords-units-01-b.svg [ ImageOnlyFailure ]
  svg/batik/filters/feTile.svg [ ImageOnlyFailure ] - linux-only?
  svg/filters/feTile.svg [ ImageOnlyFailure ]

https://codereview.appspot.com/7060043/diff/1/src/core/SkBitmapProcState.cpp
File src/core/SkBitmapProcState.cpp (right):

https://codereview.appspot.com/7060043/diff/1/src/core/SkBitmapProcState.cpp#...
src/core/SkBitmapProcState.cpp:140: // matrix.
rm extra //?

Expand All Messages | Collapse All Messages