Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(571)

Issue 7058078: Rename onFilterImageGPU to filterImageGPU(), to match skia convention. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Stephen White
Modified:
11 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Rename onFilterImageGPU to filterImageGPU(), to match skia convention. No change in functionality. (Note that this does mean that clients must override onFilterImage() to implement the raster path, but filterImageGPU() to implement the GPU path.) Committed: https://code.google.com/p/skia/source/detail?r=7123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlendImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkSingleInputImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Stephen White
PTAL
11 years, 5 months ago (2013-01-10 19:45:49 UTC) #1
bsalomon
11 years, 5 months ago (2013-01-10 19:47:19 UTC) #2
On 2013/01/10 19:45:49, Stephen White wrote:
> PTAL

lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b