Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 7057046: Output +INF and -INF as largest single precision floating point number. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by apatrick1
Modified:
11 years, 3 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In generated shaders, output +INF and -INF as largest single precision floating point number. C++ streams seem to use the representation 1.$ for INF and that isn't valid syntax in GLSL or HLSL. Also preserve the sign of INF in constant expressions that divide by zero. I can't figure out what to do about 0/0 because the shader models we are using do not support NaN. Treating it as +INF as before. Committed: https://code.google.com/p/angleproject/source/detail?r=1644

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/common/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/Intermediate.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/OutputGLSLBase.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
apatrick1
11 years, 4 months ago (2013-01-05 02:16:27 UTC) #1
kbr1
11 years, 4 months ago (2013-01-05 03:13:37 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b